Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

morph: support reloading morph endpoints with sighup #2998

Merged

Conversation

End-rey
Copy link
Contributor

@End-rey End-rey commented Nov 2, 2024

Closes #1871.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes missing coverage. Please review.

Project coverage is 23.06%. Comparing base (eccab58) to head (51dacc9).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
pkg/morph/client/reload.go 0.00% 18 Missing ⚠️
pkg/morph/client/multi.go 0.00% 4 Missing ⚠️
cmd/neofs-node/config.go 0.00% 2 Missing ⚠️
pkg/morph/client/constructor.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2998      +/-   ##
==========================================
- Coverage   23.07%   23.06%   -0.01%     
==========================================
  Files         789      790       +1     
  Lines       58687    58710      +23     
==========================================
  Hits        13542    13542              
- Misses      44263    44286      +23     
  Partials      882      882              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@End-rey End-rey force-pushed the 1871-support-reloading-morph-endpoints-with-sighup branch from 9f93904 to 85609dc Compare November 5, 2024 07:35
@End-rey End-rey force-pushed the 1871-support-reloading-morph-endpoints-with-sighup branch 2 times, most recently from d205b84 to f92c1b7 Compare November 5, 2024 15:19
@End-rey End-rey self-assigned this Nov 5, 2024
docs/sighup.md Show resolved Hide resolved
pkg/morph/client/reload.go Show resolved Hide resolved
pkg/morph/client/reload.go Show resolved Hide resolved
@End-rey End-rey force-pushed the 1871-support-reloading-morph-endpoints-with-sighup branch 3 times, most recently from 19aff22 to ac18957 Compare November 6, 2024 13:27
@carpawell carpawell requested a review from 532910 November 6, 2024 20:59
@End-rey End-rey force-pushed the 1871-support-reloading-morph-endpoints-with-sighup branch from ac18957 to 5c933da Compare November 7, 2024 13:26
@End-rey End-rey force-pushed the 1871-support-reloading-morph-endpoints-with-sighup branch from 5c933da to 34b581d Compare November 7, 2024 13:30
docs/sighup.md Outdated Show resolved Hide resolved
pkg/morph/client/constructor.go Show resolved Hide resolved
Add a new function `Client.Reload` that passes the `WithEndpoints` option and
updates the `Client` endpoints.
Closes the current connection and attempts to
reconnect if there is no endpoint in the config to which the client is
connected. Node service can be interrupted in this case.
Add docs.

Closes #1871.

Signed-off-by: Andrey Butusov <[email protected]>
@End-rey End-rey force-pushed the 1871-support-reloading-morph-endpoints-with-sighup branch from 34b581d to 51dacc9 Compare November 7, 2024 14:44
@carpawell carpawell merged commit 007e992 into master Nov 7, 2024
20 of 22 checks passed
@carpawell carpawell deleted the 1871-support-reloading-morph-endpoints-with-sighup branch November 7, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support reloading morph endpoints with SIGHUP
3 participants