Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logs: hide timestamp if the program is run not in TTY #2964

Merged
merged 1 commit into from
Oct 8, 2024
Merged

logs: hide timestamp if the program is run not in TTY #2964

merged 1 commit into from
Oct 8, 2024

Conversation

End-rey
Copy link
Contributor

@End-rey End-rey commented Oct 7, 2024

Closes #2779.

@End-rey
logs: hide timestamp if the program is run not in TTY
edc6e8f 
If inner ring or node is run in TTY then logger adds timestamp to its
entries.

Closes #2779.

Signed-off-by: Andrey Butusov <[email protected]>
@End-rey End-rey force-pushed the 2779-logs-hide-timestamp-by-default branch from 3a19c8a to edc6e8f Compare October 8, 2024 08:04
@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 23.47%. Comparing base (624f636) to head (edc6e8f).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
cmd/neofs-ir/main.go 0.00% 4 Missing ⚠️
cmd/neofs-node/config.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2964   +/-   ##
=======================================
  Coverage   23.46%   23.47%           
=======================================
  Files         776      776           
  Lines       46563    46569    +6     
=======================================
+ Hits        10928    10930    +2     
- Misses      34769    34774    +5     
+ Partials      866      865    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carpawell carpawell merged commit 530db9a into master Oct 8, 2024
19 of 21 checks passed
@carpawell carpawell deleted the 2779-logs-hide-timestamp-by-default branch October 8, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carpawell carpawell carpawell approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

logs: hide timestamp by default
3 participants
@End-rey @roman-khimov @carpawell