Fix unauthorized container ops with sessions #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, IR could approve container write operations (PUT, DELETE or SETEACL) without proper authorization: the request handler did not check public key from the session token signature against the session requester, i.e. the container owner. This created a vulnerability in which any 3rd party could sign the token and perform the operation on behalf of the container owner by specifying him as the session owner. Now all container request processors assert that session token is signed by the container owner. Otherwise, requests are denied. Fixes #2947. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
bugfix/2947-verify-session-signer
branch
from
cc55373
to
852471c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2958 +/- ##
==========================================
- Coverage 23.52% 23.52% -0.01%
==========================================
Files 776 776
Lines 46606 46619 +13
==========================================
+ Hits 10964 10967 +3
- Misses 34778 34789 +11
+ Partials 864 863 -1 ☔ View full report in Codecov by Sentry. |
Previously, CLI `util sign session-token` command unconditionally overrode issuer field to the execution wallet. This could lead to an unexpected behavior when user explicitly specified the issuer in the token and wanted to just attach signature to it. This changes the default behavior to save the issuer field and adds `--force-issuer` flag reproducing the old behavior. Refs #2947. Refs #2487. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
bugfix/2947-verify-session-signer
branch
from
852471c
to
4133364
Compare
roman-khimov
approved these changes
Oct 2, 2024
carpawell
reviewed
Oct 3, 2024
| if forceIss { | ||
| err = stok.Sign(user.NewAutoIDSignerRFC6979(*pk)) | ||
| } else { | ||
| err = stok.SetSignature(neofsecdsa.SignerRFC6979(*pk)) |
There was a problem hiding this comment.
check already attached issuer? warn/err if does not match/missing?
There was a problem hiding this comment.
i wouldnt add one more key<->user relation. And error is bad here to me cuz this utility should help, not limit. Dont think warning will be useful too: if other issuer is a problem - user will get his error later anyway, if not - there is nothing to worry bout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI change is under discussion, see #2947 (comment)