cli: do not overwrite parsed eacl rules #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for full run. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2931 +/- ##
=======================================
Coverage 23.88% 23.88%
=======================================
Files 775 775
Lines 45610 45610
=======================================
Hits 10892 10892
Misses 33861 33861
Partials 857 857 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Sep 9, 2024
Regression from c72af12. As I have already said in associated PR, new SDK turned out to be a counter-CLI thing. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/eacl-rules-parsing-in-cli
branch
from
099cf30
to
1f7d2f5
Compare
|
Taking into account nspcc-dev/neofs-testcases#848 and known issues about payment and S3 tests, it worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from c72af12. As I have already said in associated PR, new SDK turned out to be a counter-CLI thing.