workflows: add build/release workflow #2743
Conversation
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2743 +/- ##
==========================================
- Coverage 28.88% 28.86% -0.02%
==========================================
Files 415 415
Lines 32478 32478
==========================================
- Hits 9380 9376 -4
- Misses 22255 22258 +3
- Partials 843 844 +1 ☔ View full report in Codecov by Sentry. |
roman-khimov
force-pushed
the
build-release-workflow
branch
3 times, most recently
from
33847c3
to
293d68b
Compare
| - name: Set up Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '1.21' |
There was a problem hiding this comment.
it means the latest one we adopted? so after the #2738 it gonna be 1.22?
There was a problem hiding this comment.
Sure, as usual. Except that 1.22 will be added when we're to drop 1.20, not when it's the minimal one (go.mod).
| GOARCH: ${{ matrix.arch }} | ||
|
|
||
| - name: Rename binaries | ||
| run: for i in ./bin/*; do mv $i $i-${{ matrix.os.bin-name }}-${{ matrix.arch }}${{ (matrix.os.bin-name == 'windows' && '.exe') || '' }}; done |
There was a problem hiding this comment.
so we are changing our release binaries now? do we need to mention this (changelog?)?
There was a problem hiding this comment.
They'll be exactly the same (that's why they're renamed) except for missing .tar.gz. I know .tar.gz is used in some cases, but those can be reworked and this duplication was never good.
There was a problem hiding this comment.
the new "linux" word in the binary name?
There was a problem hiding this comment.
Check the binaries from https://github.com/nspcc-dev/neofs-node/actions/runs/7979125234?pr=2743, do we have correct number of linuxes there?
There was a problem hiding this comment.
Updated CHANGELOG as well, btw.
There were some fixes, but release can be tested only with a release. It at the same time is very similar to what NeoGo does. |
roman-khimov
force-pushed
the
build-release-workflow
branch
from
293d68b
to
7b5e058
Compare
And rework release procedure a bit. Don't rely on external tools and make CHANGELOGs better. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
build-release-workflow
branch
from
7b5e058
to
9c3c93e
Compare
Save artifacts, not just build them. Attach to releases. Push images. Similar to nspcc-dev/neofs-node#2743. Signed-off-by: Roman Khimov <[email protected]>
And rework release procedure a bit. Don't rely on external tools and make CHANGELOGs better.