object/search: Support numeric queries #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
force-pushed
the
feature/2730-object-search-num-match
branch
2 times, most recently
from
260be1c
to
2e5ced2
Compare
cthulhu-rider
commented
Jan 31, 2024
| for i := range prm.filters { | ||
| switch prm.filters[i].Operation() { | ||
| case object.MatchNumGT, object.MatchNumGE, object.MatchNumLT, object.MatchNumLE: | ||
| // TODO: big math takes less code but inefficient |
There was a problem hiding this comment.
optimization, suggest to defer in separate issue
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2733 +/- ##
==========================================
+ Coverage 28.86% 28.99% +0.12%
==========================================
Files 415 415
Lines 32485 32588 +103
==========================================
+ Hits 9376 9448 +72
- Misses 22265 22288 +23
- Partials 844 852 +8 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
force-pushed
the
feature/2730-object-search-num-match
branch
2 times, most recently
from
dfea573
to
042c632
Compare
cthulhu-rider
force-pushed
the
feature/2730-object-search-num-match
branch
3 times, most recently
from
6d2a6bd
to
c5a8f40
Compare
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
cthulhu-rider
force-pushed
the
feature/2730-object-search-num-match
branch
from
c5a8f40
to
c786251
Compare
roman-khimov
approved these changes
Feb 27, 2024
carpawell
reviewed
Feb 27, 2024
cthulhu-rider
force-pushed
the
feature/2730-object-search-num-match
branch
2 times, most recently
from
3f675e2
to
95079ba
Compare
cthulhu-rider
force-pushed
the
feature/2730-object-search-num-match
branch
from
95079ba
to
68d0a41
Compare
Recently, NeoFS object search protocol was extended with `<`, `<=`, `>` and `>=` numeric operators. These operators provide client comparison operations of decimal integers. `ObjectService.Search` server now supports numeric filters and handles them properly. Refs #2730. Signed-off-by: Leonard Lyubich <[email protected]>
Recently, NeoFS object search protocol was extended with `<`, `<=`, `>` and `>=` numeric operators. These operators provide client comparison operations of decimal integers. From now users can use `GT`, `GE`, `LT` and `LE` binary operators to form their numeric object queries for payload size, creation epoch or any other user-defined object attribute. Refs #2730. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
feature/2730-object-search-num-match
branch
from
68d0a41
to
b0e4662
Compare
carpawell
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP:
all ready, waiting for SDK merge