Skip to content

Commit

Permalink
Revert "[#2260] services/object: Do not assemble object with TTL=1"
Browse files Browse the repository at this point in the history
This reverts commit 907f427.

GET requests with TTL=1 are absolutely correct regardless of the need to
assemble the object. This TTL blocks request forwarding - it does not
happen. At the same time, assembling an object on the server spawns
new requests from scratch, which is not forwarding. The original commit
does not have a description of the cause, and it was never discovered.

Fixes #2447.

Signed-off-by: Leonard Lyubich <[email protected]>
  • Loading branch information
cthulhu-rider committed Feb 27, 2024
1 parent 080a35d commit f1f4286
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ Changelog for NeoFS Node

### Fixed
- Access to `PUT` objects no longer grants `DELETE` rights (#2261)
- Storage nodes no longer reject GET w/ TTL=1 requests to read complex objects (#2447)

### Changed

Expand Down
2 changes: 1 addition & 1 deletion pkg/services/object/get/exec.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func (exec execCtx) key() (*ecdsa.PrivateKey, error) {
}

func (exec *execCtx) canAssemble() bool {
return exec.svc.assembly && !exec.isRaw() && !exec.headOnly() && !exec.isLocal()
return exec.svc.assembly && !exec.isRaw() && !exec.headOnly()
}

func (exec *execCtx) splitInfo() *objectSDK.SplitInfo {
Expand Down

0 comments on commit f1f4286

Please sign in to comment.