Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add flag workers to upload-bin command #3643

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

AliceInHunterland
Copy link
Contributor

Close #3641

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.18%. Comparing base (4b10f23) to head (7b3eeb9).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
cli/util/uploader.go 33.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3643      +/-   ##
==========================================
- Coverage   83.27%   83.18%   -0.09%     
==========================================
  Files         334      334              
  Lines       46486    46488       +2     
==========================================
- Hits        38710    38672      -38     
- Misses       6200     6242      +42     
+ Partials     1576     1574       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cli/util/convert.go Outdated Show resolved Hide resolved
cli/util/uploader.go Outdated Show resolved Hide resolved
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cli: add flag workers to upload-bin command

Either "cli: add workers flag to upload-bin command" or "cli: allow to customize uploaders number for upload-bin command".

cli/util/convert.go Show resolved Hide resolved
cli/util/uploader.go Outdated Show resolved Hide resolved
docs/neofs-blockstorage.md Show resolved Hide resolved
cli/util/convert.go Outdated Show resolved Hide resolved
Number of workers to fetch, upload and search blocks concurrently is now
configurable.

Close #3641

Signed-off-by: Ekaterina Pavlova <[email protected]>
Signed-off-by: Ekaterina Pavlova <[email protected]>
@AnnaShaleva AnnaShaleva merged commit b8a65d3 into master Oct 24, 2024
33 checks passed
@AnnaShaleva AnnaShaleva deleted the uploader-workers branch October 24, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the number of uploaders for upload-bin command configurable
2 participants