cli: fix empty block uploading in util upload-bin
#3633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
AliceInHunterland
force-pushed
the
fix-empty-obj-uploading
branch
from
3b1ba95
to
e332c15
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3633 +/- ##
==========================================
- Coverage 83.33% 83.27% -0.06%
==========================================
Files 334 334
Lines 46445 46446 +1
==========================================
- Hits 38704 38679 -25
- Misses 6163 6193 +30
+ Partials 1578 1574 -4 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Oct 21, 2024
In case of uploading retry already drained bin buffer is returned in `bw.Bytes`, which leads to empty block uploading. Close #3630 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
fix-empty-obj-uploading
branch
from
e332c15
to
e00d7fe
Compare
AnnaShaleva
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3630