Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: adjust error of upload-bin command #3626

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

AliceInHunterland
Copy link
Contributor

Close #3621

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.36%. Comparing base (14ea5a8) to head (87bbff9).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
cli/util/uploader.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3626      +/-   ##
==========================================
- Coverage   84.66%   83.36%   -1.31%     
==========================================
  Files         334      334              
  Lines       39321    46440    +7119     
==========================================
+ Hits        33290    38713    +5423     
- Misses       4453     6151    +1698     
+ Partials     1578     1576       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cli/util/uploader.go Outdated Show resolved Hide resolved
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that LGTM.

cli/util/uploader.go Outdated Show resolved Hide resolved
cli/util/uploader.go Outdated Show resolved Hide resolved
Miscalculation leads to negative values in errors:
```
2024-10-17 11:26:56.790	failed to fetch the latest missing block index
 from container: search of index files failed for batch with indexes
 from -260000 to -250000: error during object IDs iteration: context
 deadline exceeded
```

Close #3621

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AnnaShaleva AnnaShaleva merged commit 8e1fdd5 into master Oct 18, 2024
30 checks passed
@AnnaShaleva AnnaShaleva deleted the uploader-errors branch October 18, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential bug in search range bounds of BlockUploader
2 participants