Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: increase NeoFS pool deadlines for upload-bin command #3625

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

AliceInHunterland
Copy link
Contributor

Close #3620

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.27%. Comparing base (8e1fdd5) to head (41873e3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3625      +/-   ##
==========================================
- Coverage   83.36%   83.27%   -0.09%     
==========================================
  Files         334      334              
  Lines       46440    46445       +5     
==========================================
- Hits        38714    38678      -36     
- Misses       6152     6193      +41     
  Partials     1574     1574              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cli/util/uploader.go Outdated Show resolved Hide resolved
cli/util/uploader.go Show resolved Hide resolved
@AnnaShaleva
Copy link
Member

Have you tried to upload with the updated timeouts? Was uploading operation interrupted by timeout?

@AliceInHunterland
Copy link
Contributor Author

Currently, the NeoFS mainnet is responding slowly or not responding at all. The pool is failing with timeouts. On the testnet, the default values have been sufficient and are still working fine. Even though testnet hardware is quite limited and should be much slower than the mainnet, it is hard to adjust the parameters accurately at this point. I tried changing both The Stream and Dual timeout settings. Only with larger values for both was the uploader able to upload a few batches, but it took a couple of hours, which is unacceptable. Now, the uploader can't even get a response from the search request. Our side is functioning as expected, but something has gone wrong on the NeoFS side.

@AliceInHunterland
Copy link
Contributor Author

just in case -s 60s should be provided for increasing neo-go timeout too

./bin/neo-go util upload-bin --cid HmP48JvCcmiEbJemG7jFNEg2qkdCTx4thD3EwWUi288Q --wallet-config ./wallet-config.yml --block-attribute block --index-attribute index --rpc-endpoint https://rpc.t5.n3.nspcc.ru:20331 -fsr st1.storage.fs.neo.org:8080 -fsr st2.storage.fs.neo.org:8080 -fsr st3.storage.fs.neo.org:8080 -fsr st4.storage.fs.neo.org:8080 -s 60s

@AnnaShaleva
Copy link
Member

for increasing neo-go timeout too

RPC client timeout doesn't affect ordinary RPC requests, AFAIK.

`defaultDialTimeout` and `defaultStreamTimeout` increased because of
`code = DeadlineExceeded desc = context deadline exceeded`

Close #3620

Signed-off-by: Ekaterina Pavlova <[email protected]>
@AnnaShaleva AnnaShaleva merged commit c962edc into master Oct 18, 2024
32 of 33 checks passed
@AnnaShaleva AnnaShaleva deleted the uploader-timeouts branch October 18, 2024 17:02
@AnnaShaleva
Copy link
Member

RPC client timeout doesn't affect ordinary RPC requests, AFAIK.

My bad, of course it does, I just missed that line in code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BlockUploader fails due to timeouts
2 participants