-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: increase NeoFS pool deadlines for upload-bin command #3625
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3625 +/- ##
==========================================
- Coverage 83.36% 83.27% -0.09%
==========================================
Files 334 334
Lines 46440 46445 +5
==========================================
- Hits 38714 38678 -36
- Misses 6152 6193 +41
Partials 1574 1574 ☔ View full report in Codecov by Sentry. |
Have you tried to upload with the updated timeouts? Was uploading operation interrupted by timeout? |
0da1cc9
to
1d2166b
Compare
Currently, the NeoFS mainnet is responding slowly or not responding at all. The pool is failing with timeouts. On the testnet, the default values have been sufficient and are still working fine. Even though testnet hardware is quite limited and should be much slower than the mainnet, it is hard to adjust the parameters accurately at this point. I tried changing both The Stream and Dual timeout settings. Only with larger values for both was the uploader able to upload a few batches, but it took a couple of hours, which is unacceptable. Now, the uploader can't even get a response from the search request. Our side is functioning as expected, but something has gone wrong on the NeoFS side. |
1d2166b
to
de60085
Compare
just in case -s 60s should be provided for increasing neo-go timeout too
|
de60085
to
27aa9eb
Compare
RPC client timeout doesn't affect ordinary RPC requests, AFAIK. |
`defaultDialTimeout` and `defaultStreamTimeout` increased because of `code = DeadlineExceeded desc = context deadline exceeded` Close #3620 Signed-off-by: Ekaterina Pavlova <[email protected]>
27aa9eb
to
41873e3
Compare
My bad, of course it does, I just missed that line in code. |
Close #3620