neotest: coverage collection polishing #3616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use calls frequency calculated by executor in the final coverage profile for `atomic` cover mode. Support only `set` cover mode for now due to #3587. Signed-off-by: Anna Shaleva <[email protected]>
Don't use panic when we can use t.Fatal. Signed-off-by: Anna Shaleva <[email protected]>
And always use pointers for coverage block processing, dereference is excessive in this context. Signed-off-by: Anna Shaleva <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3616 +/- ##
=======================================
Coverage 85.19% 85.19%
=======================================
Files 333 333
Lines 39009 39022 +13
=======================================
+ Hits 33232 33245 +13
- Misses 4207 4210 +3
+ Partials 1570 1567 -3 ☔ View full report in Codecov by Sentry. |
roman-khimov
previously approved these changes
Oct 15, 2024
I'm writing an issue about that. |
AnnaShaleva
force-pushed
the
coverage-enh
branch
from
0d9ad91
to
8e650c7
Compare
|
OK, no issue required for sorting. |
AnnaShaleva
dismissed
roman-khimov’s stale review
Coverage blocks sorting behaviour is invalid.
Make the behaviour similar to the `go test` output. It's not a problem for the `go cover` tool, but the sorted file is easier to debug and analize. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
force-pushed
the
coverage-enh
branch
from
41ee43d
to
fc6c896
Compare
Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
force-pushed
the
coverage-enh
branch
from
fc6c896
to
c1444d4
Compare
roman-khimov
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.