Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services: add new block fetching from NeoFS service #3515
services: add new block fetching from NeoFS service #3515
Changes from all commits
6f2712e
69b655e
8846f64
5dff3fc
0b31a29
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 17 in cli/server/dump_bin.go
Codecov / codecov/patch
cli/server/dump_bin.go#L17
Check warning on line 25 in cli/server/dump_bin.go
Codecov / codecov/patch
cli/server/dump_bin.go#L25
Check warning on line 28 in cli/server/dump_bin.go
Codecov / codecov/patch
cli/server/dump_bin.go#L28
Check warning on line 35 in cli/server/dump_bin.go
Codecov / codecov/patch
cli/server/dump_bin.go#L35
Check warning on line 57 in cli/server/dump_bin.go
Codecov / codecov/patch
cli/server/dump_bin.go#L57
Check warning on line 61 in cli/server/dump_bin.go
Codecov / codecov/patch
cli/server/dump_bin.go#L61
Check warning on line 67 in cli/server/dump_bin.go
Codecov / codecov/patch
cli/server/dump_bin.go#L67
Check warning on line 71 in cli/server/dump_bin.go
Codecov / codecov/patch
cli/server/dump_bin.go#L71
Check warning on line 80 in cli/server/dump_bin.go
Codecov / codecov/patch
cli/server/dump_bin.go#L80
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not
dump
, butfetch
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roman-khimov, why
fetch
? This command saves dump of every block to a separate file, it doesn't fetch them from the network.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@roman-khimov, do we need
size:128000
attribute?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as an option, various index files size for different schemas.
Check warning on line 151 in pkg/config/application_config.go
Codecov / codecov/patch
pkg/config/application_config.go#L151