config: fix TestGetConfigFromContext on Windows #3306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
AnnaShaleva
reviewed
Feb 8, 2024
AliceInHunterland
force-pushed
the
test-windows-path
branch
from
86219e9
to
0e54978
Compare
AnnaShaleva
reviewed
Feb 8, 2024
AnnaShaleva
changed the title
AliceInHunterland
force-pushed
the
test-windows-path
branch
from
0e54978
to
2e5da30
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3306 +/- ##
==========================================
- Coverage 84.96% 84.87% -0.10%
==========================================
Files 328 328
Lines 44747 44747
==========================================
- Hits 38020 37979 -41
- Misses 5216 5258 +42
+ Partials 1511 1510 -1 ☔ View full report in Codecov by Sentry. |
AliceInHunterland
force-pushed
the
test-windows-path
branch
3 times, most recently
from
5267363
to
6ffdb1a
Compare
AnnaShaleva
reviewed
Feb 9, 2024
AliceInHunterland
force-pushed
the
test-windows-path
branch
3 times, most recently
from
ceadf3c
to
c80f42a
Compare
Failing test caused by hardcoded relative path check which is different for Windows. Close #3305 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
test-windows-path
branch
from
c80f42a
to
939631c
Compare
AnnaShaleva
approved these changes
Feb 14, 2024
|
@roman-khimov, may be reviewed & merged. |
roman-khimov
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failing test caused by hardcoded relative path check which is different for Windows.
Close #3305