Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcsrv: add hardforks to getversion response #3160

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva added the rpc RPC server and client label Oct 12, 2023
@AnnaShaleva AnnaShaleva added this to the v0.103.0 milestone Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #3160 (8672952) into master (b284b90) will increase coverage by 0.00%.
Report is 14 commits behind head on master.
The diff coverage is 89.65%.

❗ Current head 8672952 differs from pull request most recent head 69a0104. Consider uploading reports for the commit 69a0104 to get more accurate results

@@           Coverage Diff           @@
##           master    #3160   +/-   ##
=======================================
  Coverage   85.36%   85.37%           
=======================================
  Files         323      323           
  Lines       43574    43603   +29     
=======================================
+ Hits        37198    37227   +29     
  Misses       4915     4915           
  Partials     1461     1461           
Files Coverage Δ
pkg/services/rpcsrv/server.go 80.89% <100.00%> (+0.04%) ⬆️
pkg/neorpc/result/version.go 95.08% <86.36%> (-4.92%) ⬇️

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pkg/neorpc/result/version.go Outdated Show resolved Hide resolved
pkg/neorpc/result/version.go Show resolved Hide resolved
@roman-khimov roman-khimov merged commit a9a848a into master Oct 16, 2023
12 of 15 checks passed
@roman-khimov roman-khimov deleted the add-version-hf branch October 16, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants