Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated things #3150

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Drop deprecated things #3150

merged 7 commits into from
Oct 10, 2023

Conversation

roman-khimov
Copy link
Member

The time has come.

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #3150 (9b8c412) into master (cef7009) will increase coverage by 0.58%.
Report is 2 commits behind head on master.
The diff coverage is 87.87%.

❗ Current head 9b8c412 differs from pull request most recent head 460362a. Consider uploading reports for the commit 460362a to get more accurate results

@@            Coverage Diff             @@
##           master    #3150      +/-   ##
==========================================
+ Coverage   84.86%   85.45%   +0.58%     
==========================================
  Files         330      323       -7     
  Lines       44337    43551     -786     
==========================================
- Hits        37628    37217     -411     
+ Misses       5198     4867     -331     
+ Partials     1511     1467      -44     
Files Coverage Δ
cli/server/server.go 68.37% <ø> (-0.54%) ⬇️
cli/wallet/nep17.go 74.31% <100.00%> (ø)
pkg/config/application_config.go 84.61% <100.00%> (-7.83%) ⬇️
pkg/config/config.go 83.33% <ø> (-1.67%) ⬇️
pkg/config/protocol_config.go 90.90% <100.00%> (-0.48%) ⬇️
pkg/network/server_config.go 89.28% <100.00%> (+37.81%) ⬆️
pkg/rpcclient/client.go 86.56% <ø> (ø)
pkg/rpcclient/local.go 87.23% <100.00%> (-0.53%) ⬇️
pkg/rpcclient/rpc.go 86.06% <100.00%> (+3.35%) ⬆️
pkg/rpcclient/wsclient.go 74.40% <100.00%> (-0.68%) ⬇️
... and 4 more

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of changes await the NeoFS and neo-bench.

pkg/rpcclient/nep17.go Show resolved Hide resolved
pkg/rpcclient/rpc.go Show resolved Hide resolved
pkg/rpcclient/rpc.go Show resolved Hide resolved
pkg/config/application_config.go Outdated Show resolved Hide resolved
pkg/core/blockchain_core_test.go Show resolved Hide resolved
@roman-khimov roman-khimov merged commit 2f747dd into master Oct 10, 2023
13 of 16 checks passed
@roman-khimov roman-khimov deleted the drop-deprecated branch October 10, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants