Add unwrap.Nothing function
#3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Nothing` function expects zero stack items and a successful invocation (HALT state). Signed-off-by: Tatiana Nesterenko <[email protected]>
tatiana-nspcc
requested review from
AnnaShaleva and
roman-khimov
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3117 +/- ##
===========================================
+ Coverage 0 84.84% +84.84%
===========================================
Files 0 330 +330
Lines 0 44343 +44343
===========================================
+ Hits 0 37625 +37625
- Misses 0 5207 +5207
- Partials 0 1511 +1511
... and 329 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roman-khimov
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A check for successful invocation (in the HALT state) that returns nothing is required.
The problem is described in #3070
Solution
Add unwrap.Nothing(aer, error) error for it, which should expect zero stack items and the HALT state.
Close #3070