Fix DBConfiguration description
#3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of three supported types (`Type`) in the `DBConfiguration` struct has been added. Signed-off-by: Tatiana Nesterenko <[email protected]>
tatiana-nspcc
requested review from
AnnaShaleva and
roman-khimov
as code owners
|
I also reviewed the description of DBConfiguration in the documentation (docs/node-configuration.md), and it looks ok to me. |
Codecov Report
@@ Coverage Diff @@
## master #3116 +/- ##
===========================================
+ Coverage 0 84.84% +84.84%
===========================================
Files 0 330 +330
Lines 0 44334 +44334
===========================================
+ Hits 0 37617 +37617
- Misses 0 5208 +5208
- Partials 0 1509 +1509 see 330 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roman-khimov
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There are incorrect values for Type in the DBConfiguration struct description.
The problem is described in #2931
Solution
Add the correct supported types (
Type) in theDBConfigurationstruct.Close #2931