*: move NVB and Conflicts attributes out of extensions #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
force-pushed
the
notary-attr-upd
branch
from
db5e635
to
833d9a7
Compare
Codecov Report
@@ Coverage Diff @@
## master #2962 +/- ##
==========================================
- Coverage 84.90% 84.62% -0.29%
==========================================
Files 330 329 -1
Lines 44349 43763 -586
==========================================
- Hits 37655 37034 -621
- Misses 5179 5225 +46
+ Partials 1515 1504 -11
... and 41 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AnnaShaleva
force-pushed
the
notary-attr-upd
branch
3 times, most recently
from
b4ce6dd
to
2fbaf97
Compare
AnnaShaleva
force-pushed
the
notary-attr-upd
branch
from
2fbaf97
to
3959794
Compare
They're a part of the regular protocol now. Signed-off-by: Anna Shaleva <[email protected]> Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
notary-attr-upd
branch
from
3959794
to
40df2ac
Compare
We no longer need P2PSigExtension flag here, conflicts attribute is a part of the normal protocol. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
notary-attr-upd
branch
from
40df2ac
to
fff7e91
Compare
AnnaShaleva
commented
Sep 4, 2023
roman-khimov
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And check that everything else is compatible with C# node.
Note that interoperable API (particularly, the
ledger.Transactionstructure) stays unchanged.Draft until neo-project/neo#2818 goes in.