network: fix TestServerRegisterPeer data race

To prevent logs after the test ends we need to properly shutdown the server. The problem is likely related to the fact that zap logger writes logs after the test ends. Signed-off-by: Ekaterina Pavlova <[email protected]>
nspcc-dev · Feb 13, 2024 · b45b9cc · b45b9cc
1 parent dbe6622
commit b45b9cc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -121,7 +121,7 @@ jobs:
     strategy:
       matrix:
         os: [ubuntu-20.04, windows-2022, macos-12]
-        go_versions: [ '1.19', '1.20', '1.21' ]
+        go_versions: [ '1.18','1.19', '1.20', '1.21' ]
         exclude:
           # Only latest Go version for Windows and MacOS.
           - os: windows-2022

diff --git a/pkg/network/server_test.go b/pkg/network/server_test.go
@@ -391,7 +391,7 @@ func startTestServer(t *testing.T, protocolCfg ...func(*config.Blockchain)) *Ser
 func startWithCleanup(t *testing.T, s *Server) {
 	go s.Start()
 	t.Cleanup(func() {
-		s.Shutdown()
+		defer s.Shutdown()
 	})
 }