Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.docker: ajust Dockerfiles for ARM-based Mac architecture #163

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

AliceInHunterland
Copy link
Contributor

@AliceInHunterland AliceInHunterland commented Apr 16, 2024

Close #162
Close #159

@AliceInHunterland AliceInHunterland changed the title C# node: Add Dockerfile for ARM-based Mac architecture NeoC# node: Add Dockerfile for ARM-based Mac architecture Apr 16, 2024
runner.sh Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@AnnaShaleva AnnaShaleva changed the title NeoC# node: Add Dockerfile for ARM-based Mac architecture .docker: add Dockerfile for ARM-based Mac architecture Apr 17, 2024
@AliceInHunterland AliceInHunterland changed the title .docker: add Dockerfile for ARM-based Mac architecture .docker: ajust Dockerfiles for ARM-based Mac architecture Apr 17, 2024
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally was able to run this with V2 compose. The updated PR looks much better than the previous version.

runner.sh Outdated Show resolved Hide resolved
runner.sh Outdated Show resolved Hide resolved
runner.sh Show resolved Hide resolved
.docker/ir/.env Outdated Show resolved Hide resolved
AnnaShaleva added a commit that referenced this pull request Apr 22, 2024
Ensure that bench is able to run on macOS. Ref. #163.

Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva added a commit that referenced this pull request Apr 22, 2024
Ensure that bench is able to run on macOS. Ref. #163.

Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva added a commit that referenced this pull request Apr 22, 2024
Ensure that bench is able to run on macOS. Ref. #163.

Signed-off-by: Anna Shaleva <[email protected]>
Publishing dotnet with -r linux-x64 is unavailable on ARM base
architecture.

Close #162

Signed-off-by: Ekaterina Pavlova <[email protected]>
README.md Outdated Show resolved Hide resolved
runner.sh Outdated Show resolved Hide resolved
runner.sh Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
runner.sh Outdated Show resolved Hide resolved
runner.sh Outdated Show resolved Hide resolved
For MacOS NEOBENCH_LOGGER should be set to json-file as journald and
syslog are not supported by this architecture.

Close #159

Signed-off-by: Ekaterina Pavlova <[email protected]>
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@AnnaShaleva AnnaShaleva merged commit 7a39b3f into master May 2, 2024
8 checks passed
@AnnaShaleva AnnaShaleva deleted the mac branch May 2, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable NeoC# node image builds for macOS Try it on an ARM-based Mac
2 participants