-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.docker: ajust Dockerfiles for ARM-based Mac architecture #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
roman-khimov and
AnnaShaleva
as code owners
April 16, 2024 13:54
AliceInHunterland
changed the title
C# node: Add Dockerfile for ARM-based Mac architecture
NeoC# node: Add Dockerfile for ARM-based Mac architecture
Apr 16, 2024
AliceInHunterland
force-pushed
the
mac
branch
2 times, most recently
from
April 16, 2024 14:24
8609d93
to
8b9366f
Compare
AnnaShaleva
reviewed
Apr 17, 2024
.docker/build/Dockerfile.sharp.sources.from_local_dependencies.mac
Outdated
Show resolved
Hide resolved
AnnaShaleva
changed the title
NeoC# node: Add Dockerfile for ARM-based Mac architecture
.docker: add Dockerfile for ARM-based Mac architecture
Apr 17, 2024
AliceInHunterland
force-pushed
the
mac
branch
4 times, most recently
from
April 17, 2024 12:11
b67d12e
to
e1f0ad6
Compare
AliceInHunterland
changed the title
.docker: add Dockerfile for ARM-based Mac architecture
.docker: ajust Dockerfiles for ARM-based Mac architecture
Apr 17, 2024
AnnaShaleva
reviewed
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally was able to run this with V2 compose. The updated PR looks much better than the previous version.
AnnaShaleva
reviewed
Apr 22, 2024
AnnaShaleva
reviewed
Apr 22, 2024
AnnaShaleva
added a commit
that referenced
this pull request
Apr 22, 2024
Ensure that bench is able to run on macOS. Ref. #163. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
added a commit
that referenced
this pull request
Apr 22, 2024
Ensure that bench is able to run on macOS. Ref. #163. Signed-off-by: Anna Shaleva <[email protected]>
AnnaShaleva
added a commit
that referenced
this pull request
Apr 22, 2024
Ensure that bench is able to run on macOS. Ref. #163. Signed-off-by: Anna Shaleva <[email protected]>
Publishing dotnet with -r linux-x64 is unavailable on ARM base architecture. Close #162 Signed-off-by: Ekaterina Pavlova <[email protected]>
AnnaShaleva
reviewed
Apr 27, 2024
AliceInHunterland
force-pushed
the
mac
branch
3 times, most recently
from
April 27, 2024 15:10
83b8d3a
to
4ebbb49
Compare
AnnaShaleva
reviewed
May 1, 2024
AliceInHunterland
force-pushed
the
mac
branch
4 times, most recently
from
May 2, 2024 05:50
1e26cc2
to
bcbcaef
Compare
For MacOS NEOBENCH_LOGGER should be set to json-file as journald and syslog are not supported by this architecture. Close #159 Signed-off-by: Ekaterina Pavlova <[email protected]>
AnnaShaleva
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #162
Close #159