workflows: add common Go linter, fix #21 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
requested review from
smallhive,
AnnaShaleva,
carpawell,
AliceInHunterland,
cthulhu-rider,
End-rey and
tatiana-nspcc
roman-khimov
force-pushed
the
add-linter
branch
from
1cda416
to
ee57c84
Compare
|
Unified config is good. Moreover each repo can tune it if required |
smallhive
approved these changes
Sep 9, 2024
End-rey
approved these changes
Sep 9, 2024
AnnaShaleva
reviewed
Sep 9, 2024
I've not noticed a lot of difference in previous runs, but let me check specific EXC* again, things may have changed over time. |
roman-khimov
changed the title
roman-khimov
force-pushed
the
add-linter
branch
from
620b3c8
to
ee57c84
Compare
tatiana-nspcc
approved these changes
Sep 9, 2024
This tries to unify golangci-lint settings we use across ~20 Go repositories and simplify maintenance. In general, we have two sources of golangci.yml files copied across different repositories: neofs-node and neo-go. They differ: * neofs-node doesn't care about tests, neo-go does * neofs-node has additional settings for gofmt/gomodguard/revive * neo-go has additional settings for issues with exclusions * neo-go doesn't use exhaustive * neofs-node doesn't use bodyclose/contextcheck/decorder/errorlint The golangci.yml added here: * cares about tests * uses additional rules from neofs-node, they're useful * drops exclusions made by neo-go settings, but keeps includes * enables all linters from both worlds Which practically means that it causes some pain below the spine for just about any repository. But likely those can be fixed. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
add-linter
branch
from
86e7a4f
to
730fc2d
Compare
|
@AnnaShaleva, I've tried to test it in nspcc-dev/neo-bench#184, but it can't properly work because of https://github.com/orgs/community/discussions/31054. At the same time I know now it will work after the merge. Also, includes are back. |
roman-khimov
changed the title
AnnaShaleva
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to unify golangci-lint settings we use across ~20 Go repositories and simplify maintenance. In general, we have two sources of golangci.yml files copied across different repositories: neofs-node and neo-go. They differ:
The golangci.yml added here:
Which practically means that it causes some pain below the spine for just about any repository. But likely those can be fixed.
Most probably there are errors in this PR, but we can't check it untill it's merged.