feat: adds checkDevEngines #116
Merged
+646
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: This module now defines an `exports` field in `package.json`. You will no longer be able to require individual files directly.
Super preliminary loop that will not even work right w/ libc
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
wraithgar
reviewed
Sep 5, 2024
|
For those wondering what |
styfle
reviewed
Sep 11, 2024
wraithgar
approved these changes
Sep 11, 2024
Merged
reggi
pushed a commit
that referenced
this pull request
Sep 11, 2024
🤖 I have created a release *beep* *boop* --- ## [7.1.0](v7.0.0...v7.1.0) (2024-09-11) ### Features * [`ebf9b9f`](ebf9b9f) [#116](#116) adds checkDevEngines (#116) (@reggi) ### Bug Fixes * [`ec4066b`](ec4066b) [#118](#118) skip network requests in report.getReport() (#118) (@wraithgar) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
reggi
added a commit
to npm/cli
that referenced
this pull request
Oct 3, 2024
This PR adds a check for `devEngines` in the current projects `package.json` as defined in the spec here: openjs-foundation/package-metadata-interoperability-collab-space#15 This PR utilizes a `checkDevEngines` function defined within `npm-install-checks` open here: npm/npm-install-checks#116 The goal of this pr is to have a check for specific npm commands `install`, and `run` consult the `devEngines` property before execution and check if the current system / environment. For `npm ` the runtime will always be `node` and the `packageManager` will always be `npm`, if a project is defined as not those two envs and it's required we'll throw. > Note the current `engines` property is checked when you install your dependencies. Each packages `engines` are checked with your environment. However, `devEngines` operates on commands for maintainers of a package, service, project when install and run commands are executed and is meant to enforce / guide maintainers to all be using the same engine / env and or versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the logic to check the new
devEnginespackage.json field.