pack prepare lifecycle script honors --ignore-scripts #7836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reggi
commented
Oct 15, 2024
| @@ -15,6 +15,7 @@ class Pack extends BaseCommand { | |||
| 'workspace', | |||
| 'workspaces', | |||
| 'include-workspace-root', | |||
| 'ignore-scripts', | |||
There was a problem hiding this comment.
this is substantive code change
| @@ -40,7 +40,7 @@ | |||
| "@npmcli/arborist": "^8.0.0", | |||
| "@npmcli/run-script": "^9.0.1", | |||
| "npm-package-arg": "^12.0.0", | |||
| "pacote": "^19.0.0" | |||
| "pacote": "github:npm/pacote#reggi/ignore-scripts" | |||
There was a problem hiding this comment.
this should not be landed
reggi
force-pushed
the
reggi/ignore-scripts2
branch
from
110fefd
to
68a8940
Compare
BREAKING CHANGE: pack prepare lifecycle script honors `--ignore-scripts`
reggi
force-pushed
the
reggi/ignore-scripts2
branch
from
0d51111
to
c4c5744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR integrating npm/pacote#407