Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new notification icons #345

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Create new notification icons #345

merged 1 commit into from
Oct 25, 2024

Conversation

kackogut
Copy link
Collaborator

@kackogut kackogut commented Oct 23, 2024 •
edited
Loading

Description

Fix notification icons on Android

Before After
Screenshot_1729716550 Screenshot_1729716728

Fixes #278

Checklist:

Creator

  • The target branch is main
  • I have updated the unreleased section of the change log
  • I have reviewed the 'files changed' tab on github to ensure all changes are as expected
  • I have added someone to review the pr

Reviewer

  • I have verified the above are all completed
  • I have run the code locally to ensure it fufills the requirements of the issue
  • I have reviewed the 'files changed' and commented on any sections which I think are not needed, incorrect or could be improved

After pull

  • If appropriate I have closed the issue/ moved the trello card

@kackogut kackogut requested a review from JElgar October 23, 2024 20:55
JElgar
JElgar approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@JElgar JElgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JElgar JElgar merged commit d2117c0 into main Oct 25, 2024
2 checks passed
@JElgar JElgar deleted the feature/278-fix-android-notification-icons branch October 25, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JElgar JElgar JElgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
now-u
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kackogut @JElgar