-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(framework): Explicitly exit workflow evaluation early after evaluating specified stepId
#6808
Open
rifont
wants to merge
3
commits into
next
Choose a base branch
from
nv-4506-failed-to-hydrate-stepid-error-with-custom-step-and-topic
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(framework): Explicitly exit workflow evaluation early after evaluating specified stepId
#6808
rifont
wants to merge
3
commits into
next
from
nv-4506-failed-to-hydrate-stepid-error-with-custom-step-and-topic
+92
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rifont
changed the title
Nv 4506 failed to hydrate stepid error with custom step and topic
fix(framework): Explicitly exit workflow evaluation early after provided Oct 30, 2024
stepId
rifont
requested review from
djabarovgeorge and
SokratisVidros
and removed request for
djabarovgeorge
October 30, 2024 19:23
rifont
changed the title
fix(framework): Explicitly exit workflow evaluation early after provided
fix(framework): Explicitly exit workflow evaluation early after evaluating provided Oct 30, 2024
stepId
stepId
rifont
changed the title
fix(framework): Explicitly exit workflow evaluation early after evaluating provided
fix(framework): Explicitly exit workflow evaluation early after evaluating specified Oct 30, 2024
stepId
stepId
@novu/client
@novu/framework
@novu/js
@novu/headless
@novu/nest
@novu/nextjs
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
@novu/stateless
commit: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
stepId
which resulted in a misleading log ofFailed to hydrate stepId
. This change adds an explicit check (a Promise cancellation token) to exit step evaluation early when the workflow is expected to conclude, preventing any further code execution including the misleading log. This approach is necessary whilst Node.js doesn't provide a native Promise cancellation API (which is a planned feature).chore
: removeora
dependency which provided a nice local Studio DX, but ultimately doesn't provide enough value for the package size. It's dependencies may also be incompatible with some serverless environments like Cloudflare. It also simplifies the test assertion.Screenshots
BEFORE - the confusing
Failed to hydrate stepId
log is presentAFTER - no confusing logs present
Expand for optional sections
Related enterprise PR
Special notes for your reviewer