Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): in-app editor base form #6801

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

LetItRock
Copy link
Contributor

What changed? Why was the change needed?

The base form UI for the In-App Editor.

TODO:

  • CodeMirror editors
  • no schema fetching; the schema generated UI form
  • the fields are not connected with react-hook-form

Screenshots

Screenshot 2024-10-30 at 12 34 39

Copy link

linear bot commented Oct 30, 2024

NV-4546 The form

Copy link

netlify bot commented Oct 30, 2024

Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit 2c778fd
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/67223cd4e1f25d00081c8233
😎 Deploy Preview https://deploy-preview-6801--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@desiprisg desiprisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on first glance. I'll see it live and approve!

<TabsList className="border-t-0">
<TabsTrigger className={tabsTriggerClassName} value="framework">
<TabsList className="border-t-0" variant="regular">
<TabsTrigger className={tabsTriggerClassName} value="framework" variant="regular">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come the regular isn't the default? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have two variants now, and I wasn't sure which one should be a default... so decided to make the shadcn one a default

apps/dashboard/src/utils/url.ts Show resolved Hide resolved
{
variants: {
size: {
default: 'h-8 px-2 [&>input]:py-1.5',
md: 'h-10 px-3 [&>input]:py-2.5',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium input styles

{...props}
/>
));
const tabsListVariants = cva('inline-flex items-center', {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tabs styled for the another variant of tabs, similar to the default shadcn


const tabsContentClassName = '!mt-0 h-full w-full px-3 py-3.5';

export const InAppEditor = () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in-app editor specific content, a lot of things is still missing:

  • CodeMirror editors
  • no schema fetching; the schema generated UI form
  • the fields are not connected with react-hook-form

<TabsList className="border-t-0">
<TabsTrigger className={tabsTriggerClassName} value="framework">
<TabsList className="border-t-0" variant="regular">
<TabsTrigger className={tabsTriggerClassName} value="framework" variant="regular">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have two variants now, and I wasn't sure which one should be a default... so decided to make the shadcn one a default

apps/dashboard/src/utils/url.ts Show resolved Hide resolved
@LetItRock LetItRock merged commit 031881a into next Oct 30, 2024
32 checks passed
@LetItRock LetItRock deleted the nv-4546-in-app-editor-base-form branch October 30, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants