chore(dashboard): in-app editor base form #6801
Conversation
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
apps/dashboard/src/components/workflow-editor/steps/edit-step-sidebar.tsx
Outdated
Show resolved
Hide resolved
| <TabsList className="border-t-0"> | ||
| <TabsTrigger className={tabsTriggerClassName} value="framework"> | ||
| <TabsList className="border-t-0" variant="regular"> | ||
| <TabsTrigger className={tabsTriggerClassName} value="framework" variant="regular"> |
There was a problem hiding this comment.
How come the regular isn't the default? 🤔
There was a problem hiding this comment.
we have two variants now, and I wasn't sure which one should be a default... so decided to make the shadcn one a default
apps/dashboard/src/components/workflow-editor/steps/in-app-editor.tsx
Outdated
Show resolved
Hide resolved
| { | ||
| variants: { | ||
| size: { | ||
| default: 'h-8 px-2 [&>input]:py-1.5', | ||
| md: 'h-10 px-3 [&>input]:py-2.5', |
There was a problem hiding this comment.
medium input styles
| {...props} | ||
| /> | ||
| )); | ||
| const tabsListVariants = cva('inline-flex items-center', { |
There was a problem hiding this comment.
the tabs styled for the another variant of tabs, similar to the default shadcn
|
|
||
| const tabsContentClassName = '!mt-0 h-full w-full px-3 py-3.5'; | ||
|
|
||
| export const InAppEditor = () => { |
There was a problem hiding this comment.
in-app editor specific content, a lot of things is still missing:
- CodeMirror editors
- no schema fetching; the schema generated UI form
- the fields are not connected with react-hook-form
| <TabsList className="border-t-0"> | ||
| <TabsTrigger className={tabsTriggerClassName} value="framework"> | ||
| <TabsList className="border-t-0" variant="regular"> | ||
| <TabsTrigger className={tabsTriggerClassName} value="framework" variant="regular"> |
There was a problem hiding this comment.
we have two variants now, and I wasn't sure which one should be a default... so decided to make the shadcn one a default
What changed? Why was the change needed?
The base form UI for the In-App Editor.
TODO:
Screenshots