-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Complete email preview logic #6772
Open
tatarco
wants to merge
6
commits into
next
Choose a base branch
from
complete-email-preview
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,395
−430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tatarco
force-pushed
the
complete-email-preview
branch
from
October 27, 2024 00:31
7321e3e
to
d68c467
Compare
tatarco
changed the title
Complete email preview
feat(api): Complete email preview logic
Oct 27, 2024
@novu/client
@novu/framework
@novu/js
@novu/headless
@novu/nextjs
@novu/node
@novu/notification-center
novu
@novu/providers
@novu/react
@novu/react-native
@novu/shared
commit: |
tatarco
force-pushed
the
complete-email-preview
branch
from
October 29, 2024 06:45
6e48216
to
f8b76bf
Compare
tatarco
force-pushed
the
complete-email-preview
branch
from
October 29, 2024 08:20
26f7473
to
7dbdccb
Compare
tatarco
force-pushed
the
complete-email-preview
branch
from
October 29, 2024 08:22
7dbdccb
to
4d97813
Compare
tatarco
force-pushed
the
complete-email-preview
branch
from
October 29, 2024 12:05
4fc79be
to
e24e62b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we do not have ee changes in this pr, we should not have this hash changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Completed the work around maily hydration and expansion, including modifying validation and preparation for payload schema restructuring
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer