Feature [RM85] Display Cards #86
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| // | ||
| // EpisodeRepository.swift | ||
| // Rick And Morty | ||
| // | ||
| // Created by Scottie Gray on 2021-08-13. | ||
| // Copyright © 2021 Novoda. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| protocol EpisodeRepositoryProtocol { | ||
| func getEpisode(from urlString: String, completion: @escaping ((Episode) -> Void)) | ||
| } | ||
|
|
||
| final class EpisodeRepository: EpisodeRepositoryProtocol { | ||
| private let rickAndMortyService: RickAndMortyServiceProtocol = RickAndMortyService() | ||
| static private var cachedEpisodeNames: [String : Episode] = [:] | ||
|
|
||
| func getEpisode(from urlString: String, completion: @escaping ((Episode) -> Void)) { | ||
| if let episode = EpisodeRepository.cachedEpisodeNames[urlString] { | ||
| completion(episode) | ||
| } else { | ||
| if let url = URL(string: urlString) { | ||
| rickAndMortyService.fetchData(url: url) { (episode: Episode) in | ||
| EpisodeRepository.cachedEpisodeNames[urlString] = episode | ||
| completion(episode) | ||
| } error: { error in | ||
| print(error.debugDescription) | ||
| return | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "66.jpeg", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // | ||
| // CharacterCardStateFactory.swift | ||
| // Rick And Morty | ||
| // | ||
| // Created by Scottie Gray on 2021-08-13. | ||
| // Copyright © 2021 Novoda. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
| import SwiftUI | ||
|
|
||
| final class CharacterCardStateFactory { | ||
| private func getStatusColor(character: Character) -> Color { | ||
| switch character.status { | ||
| case .alive: | ||
| return .green | ||
| case .dead: | ||
| return .red | ||
| default: | ||
| return .yellow | ||
| } | ||
| } | ||
|
|
||
| private func getStatusText(character: Character) -> String { | ||
| var str = "" | ||
|
There was a problem hiding this comment. Try to avoid names of variables that are not descriptive |
||
| switch character.status { | ||
| case .alive: | ||
| str = "Alive" | ||
| case .dead: | ||
| str = "Dead" | ||
| default: | ||
| str = "unknown" | ||
| } | ||
|
|
||
| return str + " - " + character.species | ||
| } | ||
|
|
||
| func createCharacterCardState(from character: Character) -> CharacterCardState { | ||
| let characterCardState = CharacterCardState( | ||
| id: character.id, | ||
| name: character.name, | ||
| imageURL: character.imageURL, | ||
| statusColor: getStatusColor(character: character), | ||
| species: character.species, | ||
| lastLocation: character.lastLocation.name, | ||
| firstEpisodeName: "", | ||
| statusText: getStatusText(character: character) | ||
| ) | ||
|
|
||
| return characterCardState | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| // | ||
| // Episode.swift | ||
| // Rick And Morty | ||
| // | ||
| // Created by Scottie Gray on 2021-08-13. | ||
| // Copyright © 2021 Novoda. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| struct Episode: Codable { | ||
| let name: String | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| // | ||
| // CharacterCardViewModel.swift | ||
| // Rick And Morty | ||
| // | ||
| // Created by Scottie Gray on 2021-08-13. | ||
| // Copyright © 2021 Novoda. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
| import SwiftUI | ||
|
|
||
|
|
||
| struct CharacterCardState { | ||
| var id: Int | ||
| var name: String | ||
| var imageURL: String | ||
| var statusColor: Color | ||
| var species: String | ||
| var lastLocation: String | ||
| var firstEpisodeName: String | ||
| var statusText: String | ||
| } | ||
|
|
||
| final class CharacterCardViewModel: ObservableObject { | ||
| @Published var cardState: CharacterCardState | ||
|
|
||
| let character: Character | ||
| private let episodeRepository: EpisodeRepositoryProtocol = EpisodeRepository() | ||
|
|
||
| init(character: Character) { | ||
| let cardStateFactory = CharacterCardStateFactory() | ||
|
|
||
| self.character = character | ||
| self.cardState = cardStateFactory.createCharacterCardState(from: character) | ||
|
|
||
| loadFirstEpisodeName() | ||
| } | ||
|
|
||
| func loadFirstEpisodeName() { | ||
| if let firstURL = character.episodeURLs.first { | ||
| episodeRepository.getEpisode(from: firstURL) { episode in | ||
| self.cardState.firstEpisodeName = episode.name | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| // | ||
| // CharacterListViewModel.swift | ||
| // Rick And Morty | ||
| // | ||
| // Created by Scottie Gray on 2021-08-13. | ||
| // Copyright © 2021 Novoda. All rights reserved. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
|
|
||
| struct CharacterListViewState { | ||
| let title: String = "Characters" | ||
| var characters: [Character] | ||
| } | ||
|
|
||
| final class CharacterListViewModel: ObservableObject { | ||
| @Published var characterListViewState: CharacterListViewState = CharacterListViewState(characters: []) | ||
|
|
||
| private let characterRepository: CharacterRepositoryProtocol = CharacterRepository() | ||
| private let characterCardStateFactory = CharacterCardStateFactory() | ||
|
|
||
| init() { | ||
| loadCharacters() | ||
| } | ||
|
|
||
| func loadCharacters() { | ||
| characterRepository.getCharacters { characters in | ||
| for character in characters { | ||
| self.characterListViewState.characters.append(character) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func loadIfNeeded(characterID: Int) { | ||
| if characterID == characterListViewState.characters.last?.id { | ||
| loadCharacters() | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you consider this to be a private extension on Character status?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be static function