Feature [RM85] Display Cards #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViewModel provides characterCardStates
Changed from get to load considering function does not return anything
Provides an episode for an episode url
A character Card is shown for each character from the R and M Api. The RemoteImage view is from stack overflow.
Character Cards are displayed on the app and more are loaded as the user scrolls.
| } | ||
|
|
||
| private func getStatusText(character: Character) -> String { | ||
| var str = "" |
There was a problem hiding this comment.
Try to avoid names of variables that are not descriptive
| import SwiftUI | ||
|
|
||
| final class CharacterCardStateFactory { | ||
| private func getStatusColor(character: Character) -> Color { |
There was a problem hiding this comment.
Have you consider this to be a private extension on Character status?
Comment on lines
+86
to
+90
|
|
||
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Just being picky here, but be careful when committing not to add whitespaces
| struct CharacterTileView_Previews: PreviewProvider { | ||
| static var previews: some View { | ||
| Group { | ||
| VStack { | ||
| CharacterCard(characterCardState: CharacterCardState(id: 2, name: "Morty", image: UIImage(named: "morty-image")!, isAlive: true, species: "Human", lastLocation: "Earth", firstEpisode: "Episode 1")) | ||
| CharacterCard(cardViewModel: CharacterCardViewModel(character: Character(id: 1, name: "Morty", species: "Human", lastLocation: LastLocation(name: "Earth", url: ""), status: .alive, imageURL: "", episodeURLs: []))) |
There was a problem hiding this comment.
I like that you're using previews. Have you thought of all the possible display views?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/orgs/novoda/projects/1#card-66586128
Character data is shown and more is loaded as the user scrolls.