Fix unescaped arguments in websockify command #1741
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tutacat
changed the title
CendioOssman
requested changes
Jan 3, 2023
utils/novnc_proxy
Outdated
| --record) RECORD_ARG="--record ${OPTARG}"; shift ;; | ||
| --syslog) SYSLOG_ARG="--syslog ${OPTARG}"; shift ;; | ||
| --record) RECORD_ARG='--record "${OPTARG}"'; shift ;; | ||
| --syslog) SYSLOG_ARG='--syslog "${OPTARG}"'; shift ;; |
There was a problem hiding this comment.
I'm afraid ' disables variable expansion, so this won't work.
|
@tutacat do you think you will get a chance to fix this? |
|
This looks better, but unfortunately, it still doesn't work. It is still splitting the words for the record, syslog and auth arguments. |
|
No response. Closing. |
|
Yes. I am a "volounteer". Not 100% of my time is github. Not all minds work the same, either. |
|
I understand, and we do try to give some time before we consider something abanonded. I can gladly reopen it if it's not abandoned and you'd like to resume the work? |
|
hiya sorry about this pull, it was easier to make a new one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When passing a path with spaces to websockify, it is incorrectly read as multiple arguments, because the args weren't enclosed in quotes.