Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing of Identity #1353

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

liranmauda
Copy link
Contributor

@liranmauda liranmauda commented May 1, 2024

Explain the changes

Fix printing of Identity

we should see in the logs:

time="2024-05-01T15:15:37Z" level=info msg="✈️  RPC: account.check_external_connection() Request: {Name:newbc EndpointType:AWS Endpoint:https://s3.amazonaws.com Identity:**** Secret:**** AuthMethod: AWSSTSARN: IgnoreNameAlreadyExist:false AzureLogAccessKeys:<nil> Region:}"

Fixes:

https://bugzilla.redhat.com/show_bug.cgi?id=2277186

Fix printing of Identity

Signed-off-by: liranmauda <[email protected]>
Copy link
Contributor

@jackyalbo jackyalbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liranmauda liranmauda merged commit 8f4aaa2 into noobaa:master May 2, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants