Updating Rook to v0.0.0-20240327231646-b6b89a012a95 #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vh05
force-pushed
the
update_rook
branch
2 times, most recently
from
3a353b0
to
6d9f15f
Compare
To accommodate the above change we are moving k8s.io/api to 0.29.3 which is effectively bringing VolumeResourceRequirements in place of ResourceRequirements PersistentVolumeClaimSpec has ResourceRequirements in 0.28.4 and here is the github link for the same https://github.com/kubernetes/api/blob/d2d5db7d05d8a0c0dfc5e76035904476a065987c/core/v1/types.go#L489C12-L489C32 and the ResourceRequirements has been replaced by VolumeResourceRequirements in 0.29.3 and the github link is below https://github.com/kubernetes/api/blob/a819b1d9bd169a0584c6d17430450ec1976c17de/core/v1/types.go#L502C12-L502C38 Since the change has happened inside PersistentVolumeClaimSpec in k8s.io/api, we can safely assume that updating to 0.29.3 from 0.28.4 wont break our code. Few more details: ResourceRequirements definition in 0.28.4 https://github.com/kubernetes/api/blob/d2d5db7d05d8a0c0dfc5e76035904476a065987c/core/v1/types.go#L2394 VolumeResourceRequirements definition in updated v0.29.3 https://github.com/kubernetes/api/blob/a819b1d9bd169a0584c6d17430450ec1976c17de/core/v1/types.go#L2608 Signed-off-by: Vinayakswami Hariharmath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To accommodate the above change we are moving k8s.io/api to 0.29.3 from 0.28.4 which is effectively bringing VolumeResourceRequirements in place of ResourceRequirements
PersistentVolumeClaimSpec had ResourceRequirements in 0.28.4 and here is the github link for the same https://github.com/kubernetes/api/blob/d2d5db7d05d8a0c0dfc5e76035904476a065987c/core/v1/types.go#L489C12-L489C32
and the ResourceRequirements has been replaced by VolumeResourceRequirements in 0.29.3 and the github link is below https://github.com/kubernetes/api/blob/a819b1d9bd169a0584c6d17430450ec1976c17de/core/v1/types.go#L502C12-L502C38
Since the change has happened inside PersistentVolumeClaimSpec in k8s.io/api, we can safely assume that updating to 0.29.3 from 0.28.4 wont break our code.
Few more details:
ResourceRequirements definition in 0.28.4
https://github.com/kubernetes/api/blob/d2d5db7d05d8a0c0dfc5e76035904476a065987c/core/v1/types.go#L2394
VolumeResourceRequirements definition in updated v0.29.3 https://github.com/kubernetes/api/blob/a819b1d9bd169a0584c6d17430450ec1976c17de/core/v1/types.go#L2608
Because of the above explained changes, we are forced to do some code level changes in the above mentioned context