Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support user-provided NSFSAccountConfig when creating OBCs #1342

Merged
merged 26 commits into from
May 15, 2024
Merged

Support user-provided NSFSAccountConfig when creating OBCs #1342

merged 26 commits into from
May 15, 2024

Conversation

Neon-White
Copy link
Contributor

@Neon-White Neon-White commented Apr 12, 2024 •
edited
Loading

Explain the changes

  • Refactor LoadBucketReplicationJSON to a generic LoadConfigurationJSON function
  • Add CLI support for passing an NSFS configuration
  • Pass NsfsAccountConfig to CreateAccountAPI when creating a new OBC
  • Add NSFS account config validation
  • Add distinguished_name support
  • Convert NsfsAccountConfig's GID and UID properties to be pointers to support a 0-value without omitempty getting rid of them
  • Fix bug that wouldn't allow setting UID/GID to 0

All the changes are needed to support a flow where the user creates a new OBC on top of an NSFS namespacestore, and would like to use the OBC's credentials to interact with the bucket

Note: path is already supported

Issues: Fixed #xxx / Gap #xxx

Fixes #958

Testing Instructions:

  1. Create an NSFS namespacestore
  2. Create a bucketclass that utilizes the NS from the previous step
  3. Create an OBC with NSFS account config that utilizes the bucketclass from the previous step
  4. Use the credentials provided after the OBC's creation to write to it
  5. Access the filesystem, verify the object was written successfully
  • Doc added/updated
  • Tests added

@Neon-White Neon-White marked this pull request as ready for review April 12, 2024 14:40
romayalon
romayalon requested changes Apr 15, 2024
View reviewed changes
pkg/validations/common_bucket_validations.go Show resolved Hide resolved
pkg/validations/common_bucket_validations.go Show resolved Hide resolved
pkg/validations/common_bucket_validations.go Show resolved Hide resolved
pkg/obc/obc.go Outdated Show resolved Hide resolved
@Neon-White Neon-White mentioned this pull request Apr 17, 2024
Open
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 17, 2024
@Neon-White Neon-White force-pushed the pass-nsfs-cfg-in-obc-creation branch from eb29062 to 489e540 Compare April 17, 2024 11:57
@Neon-White Neon-White force-pushed the pass-nsfs-cfg-in-obc-creation branch from 771e822 to 07111b1 Compare April 25, 2024 07:29
romayalon
romayalon reviewed Apr 25, 2024
View reviewed changes
doc/obc-provisioner.md Outdated Show resolved Hide resolved
@Neon-White Neon-White requested a review from romayalon May 6, 2024 22:57
@Neon-White Neon-White force-pushed the pass-nsfs-cfg-in-obc-creation branch from 62f8200 to 2f36728 Compare May 8, 2024 09:43
@Neon-White Neon-White force-pushed the pass-nsfs-cfg-in-obc-creation branch from de1dea6 to f18c606 Compare May 8, 2024 15:19
@Neon-White
- Refactor LoadBucketReplicationJSON to a generic `LoadConfiguratio…
af30078 
…nJSON` function

- Add CLI support for passing an NSFS configuration
- Pass NsfsAccountConfig to `CreateAccountAPI` when creating a new OBC
- Add NSFS account config validation

Signed-off-by: Ben <[email protected]>
@Neon-White
- Improve validation name
64883fc 
- Cater to linter

Signed-off-by: Ben <[email protected]>
@Neon-White
- Add CLI support for NSFS OBC
8ae1f8c 
- Add operator support for distinguished_name

Signed-off-by: Ben <[email protected]>
@Neon-White
Add validations for NSFS config
691c477 
Signed-off-by: Ben <[email protected]>
@Neon-White
- Add NSFS OBC docs
7d5a2bd 
- Always default to NSFS-only account creation when creating NSFS OBCs
- Recapitalize `nsfsAccountConfig` to adhere to style

Signed-off-by: Ben <[email protected]>
@Neon-White
Update CRD
9ee0003 
Signed-off-by: Ben <[email protected]>
@Neon-White
Update deploy
337165f 
Signed-off-by: Ben <[email protected]>
@Neon-White
Pass a nil config in case it isn't initialized
86ee286 
Signed-off-by: Ben <[email protected]>
@Neon-White
- Hide new_buckets_path docs
999a2cf 
- Force all NSFS OBCs to be NSFS-only, and to not accept any value for `new_buckets_path`

Signed-off-by: Ben <[email protected]>
@Neon-White
Add unit tests
a645ac2 
Signed-off-by: Ben <[email protected]>
@Neon-White
- Revert unneeded NoobaaAccount CRD change
7456eb4 
- Change UID and GID in `AccountNsfsConfig` to be pointers to allow us to pass 0-values to the core
- Revamp validations
- Add CLI tests

Signed-off-by: Ben <[email protected]>
@Neon-White
Pointerify admission test values
8a38e42 
Signed-off-by: Ben <[email protected]>
@Neon-White
Gen API
f5daf00 
Signed-off-by: Ben <[email protected]>
@Neon-White
Gen API... again
58b5022 
Signed-off-by: Ben <[email protected]>
@Neon-White Neon-White force-pushed the pass-nsfs-cfg-in-obc-creation branch from c13eeb0 to a6bfdbe Compare May 13, 2024 06:46
@Neon-White Neon-White requested a review from romayalon May 13, 2024 06:46
@Neon-White
Actually revert the CRD changes this time
73d28c5 
Signed-off-by: Ben <[email protected]>
@Neon-White
- Initialize regex compilation statically
f740063 
- Use correct controller-gen output
- Improve OBC docs
- Change CLI `distinguished-name` check to be consistent with other `distinguished-name` checks
- Add `CreateAccountAPI` clarifications for posterity
- Uncomment tests
- Validate case where YAMLs are supplied with an NSFS config but without UID/GID/DN

Signed-off-by: Ben <[email protected]>
@Neon-White
Lint
a465a43 
Signed-off-by: Ben <[email protected]>
@Neon-White
Lint properly
f9a6c81 
Signed-off-by: Ben <[email protected]>
@Neon-White
- Improve tests
835445f 
- Add bucketclass check

Signed-off-by: Ben <[email protected]>
@Neon-White
Fix tests and add empty bucketclass test
e2ef5ea 
Signed-off-by: Ben <[email protected]>
@Neon-White
Fix CLI tests
418e2bd 
Signed-off-by: Ben <[email protected]>
@Neon-White
Modify test order
a1a0300 
Signed-off-by: Ben <[email protected]>
@Neon-White
Fix bucketclass name
bc86ff1 
Signed-off-by: Ben <[email protected]>
romayalon
romayalon approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@romayalon romayalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved :)
please don't forget to squash the commits before merge :)

@Neon-White Neon-White merged commit fa6f6e4 into noobaa:master May 15, 2024
14 checks passed
@Neon-White Neon-White deleted the pass-nsfs-cfg-in-obc-creation branch May 15, 2024 16:57
@Neon-White Neon-White mentioned this pull request May 16, 2024
Closed
liranmauda pushed a commit to liranmauda/noobaa-operator that referenced this pull request Sep 9, 2024
@Neon-White @liranmauda
Support user-provided NSFSAccountConfig when creating OBCs (noobaa#1342)
9987b53 
Support user-provided NSFSAccountConfig when creating OBCs
Refactor LoadBucketReplicationJSON to a generic LoadConfigurationJSON function
Add CLI support for passing an NSFS configuration
Pass NsfsAccountConfig to CreateAccountAPI when creating a new OBC
Add NSFS account config validation
Add distinguished_name support
Convert NsfsAccountConfig's GID and UID properties to be pointers to support a 0-value without omitempty getting rid of them
Fix bug that wouldn't allow setting UID/GID to 0
Signed-off-by: Ben <[email protected]>

(cherry picked from commit fa6f6e4)
liranmauda pushed a commit to liranmauda/noobaa-operator that referenced this pull request Sep 9, 2024
@Neon-White @liranmauda
Support user-provided NSFSAccountConfig when creating OBCs (noobaa#1342)
af0c817 
Support user-provided NSFSAccountConfig when creating OBCs
Refactor LoadBucketReplicationJSON to a generic LoadConfigurationJSON function
Add CLI support for passing an NSFS configuration
Pass NsfsAccountConfig to CreateAccountAPI when creating a new OBC
Add NSFS account config validation
Add distinguished_name support
Convert NsfsAccountConfig's GID and UID properties to be pointers to support a 0-value without omitempty getting rid of them
Fix bug that wouldn't allow setting UID/GID to 0
Signed-off-by: Ben <[email protected]>

(cherry picked from commit fa6f6e4)
Signed-off-by: liranmauda <[email protected]>
liranmauda pushed a commit to liranmauda/noobaa-operator that referenced this pull request Sep 11, 2024
@Neon-White @liranmauda
Support user-provided NSFSAccountConfig when creating OBCs (noobaa#1342)
06755af 
Support user-provided NSFSAccountConfig when creating OBCs
Refactor LoadBucketReplicationJSON to a generic LoadConfigurationJSON function
Add CLI support for passing an NSFS configuration
Pass NsfsAccountConfig to CreateAccountAPI when creating a new OBC
Add NSFS account config validation
Add distinguished_name support
Convert NsfsAccountConfig's GID and UID properties to be pointers to support a 0-value without omitempty getting rid of them
Fix bug that wouldn't allow setting UID/GID to 0
Signed-off-by: Ben <[email protected]>

(cherry picked from commit fa6f6e4)
liranmauda pushed a commit to liranmauda/noobaa-operator that referenced this pull request Sep 11, 2024
@Neon-White @liranmauda
Support user-provided NSFSAccountConfig when creating OBCs (noobaa#1342)
e7e7076 
Support user-provided NSFSAccountConfig when creating OBCs
Refactor LoadBucketReplicationJSON to a generic LoadConfigurationJSON function
Add CLI support for passing an NSFS configuration
Pass NsfsAccountConfig to CreateAccountAPI when creating a new OBC
Add NSFS account config validation
Add distinguished_name support
Convert NsfsAccountConfig's GID and UID properties to be pointers to support a 0-value without omitempty getting rid of them
Fix bug that wouldn't allow setting UID/GID to 0
Signed-off-by: Ben <[email protected]>

(cherry picked from commit fa6f6e4)
Signed-off-by: liranmauda <[email protected]>
liranmauda pushed a commit to liranmauda/noobaa-operator that referenced this pull request Sep 11, 2024
@Neon-White @liranmauda
Support user-provided NSFSAccountConfig when creating OBCs (noobaa#1342)
6cb8484 
Support user-provided NSFSAccountConfig when creating OBCs
Refactor LoadBucketReplicationJSON to a generic LoadConfigurationJSON function
Add CLI support for passing an NSFS configuration
Pass NsfsAccountConfig to CreateAccountAPI when creating a new OBC
Add NSFS account config validation
Add distinguished_name support
Convert NsfsAccountConfig's GID and UID properties to be pointers to support a 0-value without omitempty getting rid of them
Fix bug that wouldn't allow setting UID/GID to 0
Signed-off-by: Ben <[email protected]>

(cherry picked from commit fa6f6e4)
Signed-off-by: liranmauda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romayalon romayalon romayalon approved these changes

@liranmauda liranmauda Awaiting requested review from liranmauda

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

missing nsfs_account_config when using noobaa obc to provision nsfs bucket+account
2 participants
@Neon-White @romayalon