Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI | Fix creation and validation of OBC with replication #1200

Merged
merged 1 commit into from
Aug 17, 2023
Merged

CLI | Fix creation and validation of OBC with replication #1200

merged 1 commit into from
Aug 17, 2023

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. In the latest validation refactoring - a64c96d , replication validation was added to OBC validations, but the cli was not able to communicate with noobaa core using an internal RPC connection, tests env var hid this issue on the CI, found it on manual testing.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon romayalon merged commit dc0dc7c into noobaa:master Aug 17, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackyalbo jackyalbo jackyalbo approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romayalon @jackyalbo