fix: PoolBase kClose and kDestroy should await and not return the Pro…

…mise (#3716)
nodejs · Oct 11, 2024 · cda5f94 · cda5f94
1 parent 9c3ed66
commit cda5f94
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/dispatcher/pool-base.js b/lib/dispatcher/pool-base.js
@@ -113,9 +113,9 @@ class PoolBase extends DispatcherBase {
 
  async [kClose] () {
  if (this[kQueue].isEmpty()) {
- return Promise.all(this[kClients].map(c => c.close()))
+ await Promise.all(this[kClients].map(c => c.close()))
  } else {
- return new Promise((resolve) => {
+ await new Promise((resolve) => {
  this[kClosedResolve] = resolve
  })
  }
@@ -130,7 +130,7 @@ class PoolBase extends DispatcherBase {
  item.handler.onError(err)
  }
 
- return Promise.all(this[kClients].map(c => c.destroy(err)))
+ await Promise.all(this[kClients].map(c => c.destroy(err)))
  }
 
  [kDispatch] (opts, handler) {