doc: add collaborators list to README #305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=========================================
- Coverage 79.21% 78.6% -0.62%
=========================================
Files 33 33
Lines 4225 4225
=========================================
- Hits 3347 3321 -26
- Misses 878 904 +26
Continue to review full report at Codecov.
|
richardlau
reviewed
Oct 2, 2019
Adding list to the README so that ncu can parse approvals correctly (without pointing to a local copy of nodejs/node README). List extracted from the `@nodejs/llnode` GitHub team.
mmarchini
force-pushed
the
collaborators-list-readme
branch
from
fb90cbd
to
aec422c
Compare
mmarchini
commented
Oct 2, 2019
| <!-- | ||
| ### TSC (Technical Steering Committee) | ||
|
|
||
| ncu-team-sync.team(nodejs/llnode) |
There was a problem hiding this comment.
I'll send a PR later to ncu to also accept this format as a way to sync teams.
richardlau
approved these changes
Oct 2, 2019
|
Meh, not worth it, especially if we adopt #370 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding list to the README so that ncu can parse approvals correctly
(without pointing to a local copy of nodejs/node README). List
extracted from the
@nodejs/llnodeGitHub team.