Fix #70: Respect PG* environment variables #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The database and sslmodel options are now handled implicitely.
If options are not specified in the connection string, the postgres driver will pick the corresponding environment variables. Therefore this commit changes the default connection string to the empty string. This commit fixes nnev#70.
Setting the argument is not necessary anymore, because the default values are taken from the environment.
|
Note that this PR does not only change the default connect string for the There are some systemd service files in the repo. Either the environment variables (PGHOST should be default, so PGDATABASE should be enough) should be set, or a correct |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #70. The change is rather simple, because this is already the default behaviour of the postgres driver when the connection string is empty.