To reduce the chance of flaky test failure #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This test is flakily fails. I run this test many times and it makes assertion fails. The failure message is as follows.
Failure:
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.51 s <<< FAILURE! - in nl.nlighten.prometheus.tomcat.TomcatServletMetricsFilterTest
[ERROR] testServletRequestMetrics(nl.nlighten.prometheus.tomcat.TomcatServletMetricsFilterTest) Time elapsed: 0.01 s <<< FAILURE!
java.lang.AssertionError:
Expected: is a value greater than <0.0>
but: <0.0> was equal to <0.0>
at nl.nlighten.prometheus.tomcat.TomcatServletMetricsFilterTest.testServletRequestMetrics(TomcatServletMetricsFilterTest.java:31)
[ERROR] Failures:
[ERROR] TomcatServletMetricsFilterTest.testServletRequestMetrics:31
Expected: is a value greater than <0.0>
but: <0.0> was equal to <0.0>
[INFO]
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0