fix for empty GEOTARGETS_GDAL_RASTER_CREATION_OPTIONS #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! That's a good catch. I think writing a test here would be a good idea (I'm very happy to tackle that!) - lodged #41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #30 I replaced the
unsetvalue returned bySys.getenv()for GEOTARGETS_GDAL_RASTER_CREATION_OPTIONSCalling
strsplit("", ";)[[1]]returnscharacter(0), which will cause an error inSys.getenv(). This PR gets us the intended default value of""