Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nonbreaking packages and go version from 1.21 to 1.23 #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johnnyCake1
Copy link
Collaborator

@johnnyCake1 johnnyCake1 commented Oct 25, 2024

What has been done:

  • Upgraded go version from 1.21 to 1.23 (including the docker image version)
  • Upgraded nonbreaking packages:
    • To check if an upgrade is breaking or not, I ran go get <package>@latest for every package separately and built and ran the project and made sure everything is working same as before
    • Additionally executed existing tests for every package upgrade
  • This also fixes govulncheck that is currently failing in CI/CD because github.com/labstack/echo/v4 was upgraded
  • Packages that can be (and should be) upgraded or replaced, but they have breaking changes:
    • github.com/ShkrutDenis/go-migrations: v1.2.1 -> v1.2.10 --> very old
    • gorm.io/driver/mysql: 1.5.2 -> v1.5.7
    • gorm.io/gorm: v1.25.5 -> v1.25.12

Notes:

  • Migrations code and tests should be updated to adopt newer versions of packages that are listed above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants