Allow to configure bootSize in specialArgs
#368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ereslibre
force-pushed
the
configure-boot-size
branch
2 times, most recently
from
ecbb9a4
to
ff874c3
Compare
Update `qcow-efi` to not define module options and use `specialArgs` as the rest of the formats, in order to improve format backend consistency. Porting all of them to module options would be cleaner though.
ereslibre
force-pushed
the
configure-boot-size
branch
from
ff874c3
to
e73bd8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for
nixos-generators!Fixes: #369
This PR allows to configure the
/bootpartition size on those formats that specify one. It also provides the ability to set the flag from the command line with the--boot-sizeparameter that specifies the size of the partition in MB, similar to the--disk-sizeparameter.This PR also updates the
qcow-efi.nixformat because it was an outlier in the implementation. It defines module options that are not set in any of the machinery closer to the user. All formats are usingspecialArgs, except forqcow-efi.nix.I have seen on #204 that this was one of the suggested changes by @Mic92, but I think it's a bit misleading because those options are disconnected from any setting the user can configure.
Having modules in all formats with their options and whatnot would be a cleaner solution than using
specialArgs, but I'd tackle that refactor as a specific work on its own. In the meantime, I think it's worth having consistency across different format implementations.All tests are passing locally. I have tested it building a NixOS environment to
qcow-efiand use it as part of my daily driver, I usually run out of space on my/bootpartition on the VM I work on and while cleaning up works, having a bigger/bootpartition helps.