Feature/builtins fetchgit #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraem
force-pushed
the
feature/builtins-fetchgit
branch
from
b0cfe1f
to
ccfc8e6
Compare
By doing this Bundix can make use of fetchGit's ability to clone private repos. The responsibility for fetching a sha256 of the checkout is moved from Bundix -> builtins.fetchGit. Signed-off-by: kraem <[email protected]>
Signed-off-by: kraem <[email protected]>
Signed-off-by: kraem <[email protected]>
Signed-off-by: kraem <[email protected]>
Signed-off-by: kraem <[email protected]>
kraem
force-pushed
the
feature/builtins-fetchgit
branch
from
ccfc8e6
to
600ca13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully solves #69
Works in tandem with https://github.com/kraem/nixpkgs/blob/bb4b2da585dd0186b3c1cec9fb9f7f9227cf428c/pkgs/development/ruby-modules/gem/default.nix#L67-L70I'll create a PR in
nixpkgsfor that as soon as this has been reviewed and approved 👍edit
Apparently the bin wrappers innixpkgsfor gems needs some more work before this is ready. The gems gets installed, but in in the wrong path in/nix/store./edit
edit2
Now works in tandem with this fork
nixpkgs. Haven't tried with private git gems that have executables yet./edit2
The responsibility for fetching the repo and calculating a
sha256is now transfered tonix'sbuiltins.fetchGitwhich doesn't do it in a sandbox but can use the current userssshcredentials.All gems fetched from git now gets the type
buitlins-git, but the old typegitis saved inbundlerEnvfor backwards compatibility.Thanks a lot for your time to explain how all of this fits together @manveru
I haven't written many lines ruby before so I'm sure there are a lot of things that could look nicer.