Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scan route files with other chars in param name #2872

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 11, 2024

resolves #2868

radix3 matcher allows wider matches per segment (as long as starts or in newer version contains :).

This PR relaxes /[param]/ to /:param/ normalization regex.

@pi0 pi0 self-assigned this Nov 11, 2024
Copy link

Deploying nitrojs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 21f0c08
Status: ✅  Deploy successful!
Preview URL: https://bef5ed1c.nitrojs.pages.dev
Branch Preview URL: https://fix-scan-params.nitrojs.pages.dev

View logs

@pi0 pi0 merged commit 9563e9a into v2 Nov 11, 2024
5 checks passed
@pi0 pi0 deleted the fix/scan-params branch November 11, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

route files with - in param name are not scanned
1 participant