Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(netlify): only include env polyfill in netlify-edge #2851

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

serhalp
Copy link
Contributor

@serhalp serhalp commented Nov 5, 2024

πŸ”— Linked issue

Discussed on Discord. Possibly also related to https://discord.com/channels/473401852243869706/1303374973465006102/1303374973465006102.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

93d002b introduced a regression by importing the Deno env polyfill in all Netlify presets rather than just the Netlify Edge preset(s). This fixes that.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Only the Netlify Edge environment is a Deno environment.
@serhalp serhalp requested a review from pi0 as a code owner November 5, 2024 17:51
@pi0 pi0 changed the title fix: don't import Deno polyfill for non-Deno Netlify environments fix(deno): only include env polyfill in netlify-edge Nov 5, 2024
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 changed the title fix(deno): only include env polyfill in netlify-edge fix(netlify): only include env polyfill in netlify-edge Nov 5, 2024
@pi0 pi0 merged commit fe50a4e into nitrojs:v2 Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants