Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(cache): resolved value is not nullable #2848

Merged
merged 1 commit into from
Nov 5, 2024
Merged

types(cache): resolved value is not nullable #2848

merged 1 commit into from
Nov 5, 2024

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Nov 5, 2024

ref: #2829 (comment) resolves #2847

Resolved cache functions always have .value. This PR fixes types (which got stricter in 2.10+)

@pi0 pi0 self-assigned this Nov 5, 2024
Copy link

Deploying nitrojs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f1116c5
Status: ✅  Deploy successful!
Preview URL: https://0ae09fc2.nitrojs.pages.dev
Branch Preview URL: https://types-cache-res.nitrojs.pages.dev

View logs

@pi0 pi0 merged commit e728f9b into v2 Nov 5, 2024
5 checks passed
@pi0 pi0 deleted the types/cache-res branch November 5, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inaccurate return type of defineCacheFunction (typescript)
1 participant