Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(render_com): update instructions #2536

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

MickL
Copy link
Contributor

@MickL MickL commented Jun 15, 2024

πŸ”— Linked issue

#2535

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

There is no need for the render.com preset. I updated the steps to the latest render.com UI and I also added Bun as an alternative runtime which render.com supports

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

There is no need for the `render.com` preset. I updated the steps to the latest render.com UI and I also added Bun as an alternative runtime which render.com supports
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR. Left some suggestions. I love to followup on this PR as improvement to current docs:

  • Add bun instructions
  • Add UI wizard alternative to config usage


1. [Create a new Web Service](https://dashboard.render.com/select-repo?type=web) and select the repository that contains your code.
2. Ensure the 'Node' environment is selected.
3. Update the start command to `node .output/server/index.mjs`
4. Click 'Advanced' and add an environment variable with `NITRO_PRESET` set to `render_com`. You may also need to add a `NODE_VERSION` environment variable set to `18` for the build to succeed ([docs](https://render.com/docs/node-version)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are reasons we have explicit preset please keep it.

docs/2.deploy/20.providers/render.md Outdated Show resolved Hide resolved
envVars:
- key: NITRO_PRESET
value: render_com
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this as alternative to web UI setup wizard.

docs/2.deploy/20.providers/render.md Outdated Show resolved Hide resolved
@pi0 pi0 marked this pull request as draft June 17, 2024 09:23
@pi0 pi0 changed the title docs: Updated provider "render.com" docs(render_com): update instructions Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants