-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node-server): add env variables for timeout setting in node-server runtimes #1944
base: main
Are you sure you want to change the base?
Conversation
β Live Preview ready!
|
Thanks for this PR. It makese sense to allow supporting more customizations for Node runtime server but adding more as direct env variables might be a tricky task to maintain. I am pending PR to think little more what would be alternative. |
Hi @pi0, do you have an idea for a better solution than the one provided by @lastmirage? |
@pi0 any chance to have an update here? Thanks! |
Hey @pi0, first of all I want to thank you for your effort and time you put in to all of this, I know it is not easy, the web space became so complicated, we have now different runtimes, so many ways to deploy apps, so many infra variations, and I guess making sure all of this works is not an easy task, again thank you. |
I am thinking to finally land it for v2 at least (but need to cleanup changes little bit before merge). (this is what working on for Nitro v3: spoiler - i hope to find a better standard away to set these regardless of runtime and also framework so it won't be nitro specific convention) |
@pi0 Awesome, thanks. |
π Linked issue
β Type of change
π Description
When deploy node runtime to behind AWS ELB, timeout missmatching can leads to 502 error.
For resolve this error, we have to set timeout values in HttpServer.
π Checklist