Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-server): add env variables for timeout setting in node-server runtimes #1944

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lastmirage
Copy link

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When deploy node runtime to behind AWS ELB, timeout missmatching can leads to 502 error.
For resolve this error, we have to set timeout values in HttpServer.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Contributor

nuxt-studio bot commented Nov 22, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview c989cd5

@pi0
Copy link
Member

pi0 commented Nov 22, 2023

Thanks for this PR. It makese sense to allow supporting more customizations for Node runtime server but adding more as direct env variables might be a tricky task to maintain.

I am pending PR to think little more what would be alternative.

@pi0 pi0 marked this pull request as draft April 29, 2024 18:29
@unite4
Copy link

unite4 commented Aug 21, 2024

Hi @pi0, do you have an idea for a better solution than the one provided by @lastmirage?

@joaoaraujo-hotmart
Copy link

@pi0 any chance to have an update here? Thanks!

@vsergiu93
Copy link

Hey @pi0, first of all I want to thank you for your effort and time you put in to all of this, I know it is not easy, the web space became so complicated, we have now different runtimes, so many ways to deploy apps, so many infra variations, and I guess making sure all of this works is not an easy task, again thank you.
I just want to ask you about this issue, do you guys plan to add something in the next major release that will allow us to configure this values, either how is proposed here or maybe in a different way?

@pi0
Copy link
Member

pi0 commented Sep 20, 2024

I am thinking to finally land it for v2 at least (but need to cleanup changes little bit before merge).

(this is what working on for Nitro v3: spoiler - i hope to find a better standard away to set these regardless of runtime and also framework so it won't be nitro specific convention)

@vsergiu93
Copy link

@pi0 Awesome, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants