Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting rewrite option for devProxy #1893

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gliheng
Copy link

@gliheng gliheng commented Nov 8, 2023

πŸ”— Linked issue

#1892

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR adds a path rewrite option to devProxy config.
This is useful in case that user wants to change request path, before the request is sent to upstream server.

Resolves #1892

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Copy link
Contributor

nuxt-studio bot commented Nov 8, 2023

βœ… Live Preview ready!

Name Edit Preview Latest Commit
nitro Edit on Studio β†—οΈŽ View Live Preview b44aab6

src/dev/server.ts Outdated Show resolved Hide resolved
@gliheng
Copy link
Author

gliheng commented Nov 11, 2023

event.path is also updated now

@pi0
Copy link
Member

pi0 commented Nov 20, 2023

Thanks! Sorry for delay. I am thinking to move this feature directly to httpxy.

@gliheng
Copy link
Author

gliheng commented Nov 22, 2023

OK, close this PR if you want.

@pi0 pi0 marked this pull request as draft April 29, 2024 18:29
@pi0
Copy link
Member

pi0 commented Apr 29, 2024

(sorry for delay, rewrite should be implemented in upstream but we might also type it in nitro + consider a serialzable rewrite for production, that's why keeping it open)

@gliheng gliheng marked this pull request as ready for review May 1, 2024 14:36
@pi0 pi0 marked this pull request as draft May 1, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devProxy need rewrite option to rewrite request path
2 participants